Add pvlib.spa.transit_sunrise_sunset to documentation - #2873
Open
AdamRJensen wants to merge 2 commits into
Open
AdamRJensen wants to merge 2 commits into
AdamRJensen wants to merge 2 commits into
Conversation
cwhanse
approved these changes
Oct 4, 2026
echedey-ls
approved these changes
Oct 5, 2026
RDaxini
approved these changes
Oct 5, 2026
| """ | ||
| Calculate the sun transit, sunrise, and sunset | ||
| for a set of dates at a given location. | ||
| for a set of dates at a given location using the NREL SPA [1]_. |
Member
There was a problem hiding this comment.
suggestion contingent on #2873 (comment)
Suggested change
| for a set of dates at a given location using the NREL SPA [1]_. | |
| for a set of dates at a given location using the NREL SPA [1]_, [2]_. |
| .. [1] I. Reda and A. Andreas, Solar position algorithm for solar | ||
| radiation applications. Solar Energy, vol. 76, no. 5, pp. 577-589, | ||
| 2004. :doi:`10.1016/j.solener.2003.12.003` | ||
| """ |
Member
There was a problem hiding this comment.
Should we cite the corrigendum as well? Open question from me, not a direct suggestion. My first thought is that it might be helpful to users for completeness at no cost.
Note: we do cite both in spa.solar_position
Suggested change
| """ | |
| References | |
| ---------- | |
| .. [1] I. Reda and A. Andreas, Solar position algorithm for solar | |
| radiation applications. Solar Energy, vol. 76, no. 5, pp. 577-589, | |
| 2004. :doi:`10.1016/j.solener.2003.12.003` | |
| .. [2] I. Reda, and A. Andreas. "Corrigendum to “Solar position | |
| algorithm for solar radiation applications." [Solar Energy 76 | |
| (2004) 577–589] Solar Energy, vol. 81, no. 6, pp. 838, 2007. | |
| :doi:`10.1016/j.solener.2007.01.003` | |
| """ |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transit_sunrise_sunset: seems as a public function, not in public docs? #2255docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Add transit_sunrise_sunset function to documentation. See #2255.